chore(engx): Remove obsolete TODOs in codegen src

miraleung · miraleung · commit 5a02acae2742 · 2021-04-06T21:48:12.000-07:00
diff --git a/src/main/java/com/google/api/generator/engine/lexicon/Literal.java b/src/main/java/com/google/api/generator/engine/lexicon/Literal.java
@@ -16,7 +16,6 @@
 
 import java.util.regex.Pattern;
 
-// TODO(miraleung): Refactor this out into int, bool, null, float, string literal classes.
 public class Literal {
   private static final String BOOLEAN_TRUE = "true";
   private static final String BOOLEAN_FALSE = "false";
diff --git a/src/main/java/com/google/api/generator/gapic/composer/ServiceClientTestClassComposer.java b/src/main/java/com/google/api/generator/gapic/composer/ServiceClientTestClassComposer.java
@@ -1288,7 +1288,6 @@ private static MethodDefinition createStreamingRpcTestMethod(
    * @param resourceNames the resource names available for use.
    * @param messageTypes the proto message types available for use.
    */
-  // TODO(miraleung): Reorder params.
   private static MethodDefinition createRpcExceptionTestMethod(
       Method method,
       Service service,
diff --git a/src/main/java/com/google/api/generator/gapic/composer/ServiceStubSettingsClassComposer.java b/src/main/java/com/google/api/generator/gapic/composer/ServiceStubSettingsClassComposer.java
@@ -247,7 +247,6 @@ private static Map<String, VariableExpr> createMethodSettingsClassMemberVarExprs
     Map<String, VariableExpr> varExprs = new LinkedHashMap<>();
 
     // Creates class variables <method>Settings, e.g. echoSettings.
-    // TODO(miraleung): Handle batching here.
     for (Method method : service.methods()) {
       boolean hasBatchingSettings =
           !Objects.isNull(serviceConfig) && serviceConfig.hasBatchingSetting(service, method);
diff --git a/src/main/java/com/google/api/generator/gapic/composer/resourcename/ResourceNameHelperClassComposer.java b/src/main/java/com/google/api/generator/gapic/composer/resourcename/ResourceNameHelperClassComposer.java
@@ -191,9 +191,7 @@ private static List<Statement> createClassStatements(
     //         "projects/{project}/locations/{location}/autoscalingPolicies/{autoscaling_policy}");
     for (int i = 0; i < patterns.size(); i++) {
       VariableExpr varExpr =
-          templateFinalVarExprs
-              .get(i)
-              .toBuilder()
+          templateFinalVarExprs.get(i).toBuilder()
               .setIsDecl(true)
               .setScope(ScopeNode.PRIVATE)
               .setIsStatic(true)
@@ -215,9 +213,7 @@ private static List<Statement> createClassStatements(
     }
 
     memberVars.add(
-        FIXED_CLASS_VARS
-            .get("fieldValuesMap")
-            .toBuilder()
+        FIXED_CLASS_VARS.get("fieldValuesMap").toBuilder()
             .setIsDecl(true)
             .setScope(ScopeNode.PRIVATE)
             .setIsVolatile(true)
@@ -248,7 +244,6 @@ private static List<MethodDefinition> createClassMethods(
       Map<String, VariableExpr> patternTokenVarExprs,
       List<List<String>> tokenHierarchies,
       TypeStore typeStore) {
-    // TODO(summerji): Add equals and hashCode overrides.
     List<MethodDefinition> javaMethods = new ArrayList<>();
 
     javaMethods.addAll(
@@ -1452,9 +1447,7 @@ private static ClassDefinition createNestedBuilderClass(
                 .setStaticReferenceType(FIXED_TYPESTORE.get("Objects"))
                 .setMethodName("equals")
                 .setArguments(
-                    FIXED_CLASS_VARS
-                        .get("pathTemplate")
-                        .toBuilder()
+                    FIXED_CLASS_VARS.get("pathTemplate").toBuilder()
                         .setExprReferenceExpr(outerClassVarExpr)
                         .build(),
                     templateFinalVarExpr)
@@ -1482,8 +1475,7 @@ private static ClassDefinition createNestedBuilderClass(
             AssignmentExpr.builder()
                 .setVariableExpr(currClassTokenVarExpr)
                 .setValueExpr(
-                    currClassTokenVarExpr
-                        .toBuilder()
+                    currClassTokenVarExpr.toBuilder()
                         .setExprReferenceExpr(outerClassVarExpr)
                         .build())
                 .build());
