fix: handle installation id for GCP org#364
Merged
Conversation
google-cla
Bot
added
the
cla: yes
dazuma
approved these changes
Sep 14, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Sep 14, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.8.1](https://www.github.com/googleapis/releasetool/compare/v1.8.0...v1.8.1) (2021-09-14) ### Bug Fixes * handle installation id for GCP org ([#364](https://www.github.com/googleapis/releasetool/issues/364)) ([ee33b52](https://www.github.com/googleapis/releasetool/commit/ee33b52d535561f407bda2274c2f4e708bcd6e3f)) * **ruby:** Fix Kokoro job mapping for several Ruby repos ([#357](https://www.github.com/googleapis/releasetool/issues/357)) ([22751cc](https://www.github.com/googleapis/releasetool/commit/22751cc095d226959c5068120fe34ae7a197e5aa)) * **ruby:** Identify additional Ruby monorepos ([#360](https://www.github.com/googleapis/releasetool/issues/360)) ([7986ae4](https://www.github.com/googleapis/releasetool/commit/7986ae490269afeedae918d0a2476bfc39bf22b0)) * stop handling java repos - they are migrated to release-please/release-trigger ([#362](https://www.github.com/googleapis/releasetool/issues/362)) ([0ce5788](https://www.github.com/googleapis/releasetool/commit/0ce578853ccfa61f5c59bec6229042fc704e56bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
INSTALLATION_ID_PATHenv variable is the path to a file that contains the app installation id (needed for obtaining an app installation token). We only had this for the googleapis organization, but we need to run on the GoogleCloudPlatform organization as well.This conditionally sets the environment variable based on whether we see the respective id file in the expected location.