fix: revert to using importlib for dynamic module loading#326
Merged
chingor13 merged 1 commit intogoogleapis:masterfrom May 6, 2021
Merged
fix: revert to using importlib for dynamic module loading#326chingor13 merged 1 commit intogoogleapis:masterfrom
chingor13 merged 1 commit intogoogleapis:masterfrom
Conversation
google-cla
Bot
added
the
cla: yes
stephaniewang526
approved these changes
May 6, 2021
Neenu1995
approved these changes
May 6, 2021
Contributor
Author
|
I will followup with more tests to figure out why our tests did not catch this, but will merge this first to unblock our releases. |
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
May 11, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.6.1](https://www.github.com/googleapis/releasetool/compare/v1.6.0...v1.6.1) (2021-05-11) ### Bug Fixes * **deps:** lock click to 7.x ([#333](https://www.github.com/googleapis/releasetool/issues/333)) ([1cc456c](https://www.github.com/googleapis/releasetool/commit/1cc456c3457304a8301f64b03941f05648b96642)) * limit autorelease trigger job to recent release PRs ([#328](https://www.github.com/googleapis/releasetool/issues/328)) ([3674d7c](https://www.github.com/googleapis/releasetool/commit/3674d7c94aa396925e5d7c5bf97d35563a112d2b)) * only trigger Kokoro jobs once ([#331](https://www.github.com/googleapis/releasetool/issues/331)) ([83b0cae](https://www.github.com/googleapis/releasetool/commit/83b0caec767f8dc540f83f3e54c895d82901ea01)) * revert to using importlib for dynamic module loading ([#326](https://www.github.com/googleapis/releasetool/issues/326)) ([56a75c8](https://www.github.com/googleapis/releasetool/commit/56a75c800875e7420405559f626683731e56fb5b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #325
This is the method for dynamic module loading used in the
tagjob - thegetattrmethod looks cleaner, but is failing at runtime (but not test time?)See #314 (comment)