Skip to content

feat: add autorelease.trigger command#314

Merged
SurferJeffAtGoogle merged 15 commits intogoogleapis:masterfrom
chingor13:autorelease-trigger
Apr 28, 2021
Merged

feat: add autorelease.trigger command#314
SurferJeffAtGoogle merged 15 commits intogoogleapis:masterfrom
chingor13:autorelease-trigger

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Apr 5, 2021

This trigger will run on a cron. It will scan the googleapis org for merged pull requests with autorelease: tagged labels. For each found pull request, it will trigger the associated Kokoro job.

Implementation-wise, it's essentially the same workflow as the tag job, but looks for a different label and only handles the kokoro triggering (no tagging).

@chingor13 chingor13 requested a review from a team April 5, 2021 20:09
@chingor13 chingor13 marked this pull request as draft April 5, 2021 20:09
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 5, 2021
@jskeet
Copy link
Copy Markdown
Contributor

jskeet commented Apr 5, 2021

How easy would it be to make it handle the GoogleCloudPlatform org as well as googleapis? Basically if now is a good time to fix #287 that would be great :)

@chingor13
Copy link
Copy Markdown
Contributor Author

How easy would it be to make it handle the GoogleCloudPlatform org as well as googleapis? Basically if now is a good time to fix #287 that would be great :)

Proposed a fix separately for the autorelease.tag job in #316

@chingor13 chingor13 marked this pull request as ready for review April 22, 2021 19:29
Comment thread .kokoro-autorelease/trigger.cfg Outdated
Comment thread autorelease/trigger.py Outdated
Comment thread autorelease/trigger.py Outdated
Comment thread autorelease/trigger.py Outdated
Comment thread autorelease/trigger.py
@@ -0,0 +1,125 @@
# Copyright 2021 Google LLC
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests.

Comment thread autorelease/trigger.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants