Conversation
google-cla
Bot
added
the
cla: yes
chingor13
reviewed
Aug 26, 2020
Contributor
SurferJeffAtGoogle
left a comment
SurferJeffAtGoogle
left a comment
There was a problem hiding this comment.
This looks like solid Python. You're too humble about your Python skills. 😊
added 8 commits
August 26, 2020 09:42
SurferJeffAtGoogle
approved these changes
Aug 26, 2020
chingor13
reviewed
Aug 26, 2020
Co-authored-by: Jeff Ching <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR assumes that we will set three secrets:
APP_ID: path to a file that contains a GitHub application ID.INSTALLATION: path to a file that contains an installation ID.GITHUB_PRIVATE_KEY: path to a file that contains the PEM secret for a GitHub application.If these environments are found set, then rather than using magic-proxy, it grabs a JWT for our application and uses it to authenticate.
Note: I'm not sure of a great way to write tests for this, but I've done an end to end testing, and confirmed the approach works.