fix: limit autorelease trigger job to recent release PRs (#328)

chingor13 · web-flow · commit 3674d7c94aa3 · 2021-05-10T09:46:25.000-07:00
* fix: limit autorelease trigger job to recent release PRs

* docs: add comment about updating the CREATED_AFTER constant

* test: fix test

* test: fix test
diff --git a/autorelease/github.py b/autorelease/github.py
@@ -90,13 +90,16 @@ def list_org_repos(self, org: str, type: str = None) -> Generator[dict, None, No
             url = response.links.get("next", {}).get("url")
 
     def list_org_issues(
-        self, org: str, state: str = None, labels: str = None
+        self, org: str, state: str = None, labels: str = None, created_after: str = None
     ) -> Generator[dict, None, None]:
         url = f"{self.GITHUB_ROOT}/search/issues?q=org:{quote(org)}+state:{quote(state)}+archived:false"
         if labels:
             # Note: GitHub query API expects label to be enclosed in quotes:
             quotedLabels = '"' + labels + '"'
             url += f"+label:{quote(quotedLabels)}"
+        if created_after:
+            url += f"+created:>{created_after}"
+        print(url)
         # GitHub sometimes returns 5xx errors for this request.
         # Retry after 500, 502 response up to 4 times.
         max_retries = Retry(status=4, status_forcelist=[500, 502])
diff --git a/autorelease/trigger.py b/autorelease/trigger.py
@@ -21,6 +21,10 @@
 LANGUAGE_ALLOWLIST = ["java"]
 ORGANIZATIONS_TO_SCAN = ["googleapis", "GoogleCloudPlatform"]
 
+# Whenever we add new languages to the allowlist, update this value as
+# well to prevent trying to release old versions.
+CREATED_AFTER = "2021-04-01"
+
 
 def trigger_kokoro_build_for_pull_request(
     kokoro_session, gh: github.GitHub, issue: dict, result
@@ -100,6 +104,8 @@ def main(github_token, kokoro_credentials) -> reporter.Reporter:
                 state="closed",
                 # Must be labeled with "autorelease: pending"
                 labels="autorelease: tagged",
+                # Only look at issues created recently
+                created_after=CREATED_AFTER,
             )
 
             # Just in case any non-PRs got in here.
diff --git a/tests/test_autorelease_trigger.py b/tests/test_autorelease_trigger.py
@@ -49,10 +49,16 @@ def test_processes_issues(
     list_org_issues.side_effect = [[pr1, pr2]]
     trigger.main("github-token", "kokoro-credentials")
     list_org_issues.assert_any_call(
-        org="googleapis", state="closed", labels="autorelease: tagged"
+        org="googleapis",
+        state="closed",
+        labels="autorelease: tagged",
+        created_after="2021-04-01",
     )
     list_org_issues.assert_any_call(
-        org="GoogleCloudPlatform", state="closed", labels="autorelease: tagged"
+        org="GoogleCloudPlatform",
+        state="closed",
+        labels="autorelease: tagged",
+        created_after="2021-04-01",
     )
     assert trigger_kokoro_build_for_pull_request.call_count == 2
 
