fix: skip entire tag workflow for languages not in the allowlist (#495)

chingor13 · web-flow · commit 118f2032f811 · 2023-02-03T11:05:24.000-08:00
* fix: skip entire tag workflow for languages not in the allowlist

* test: fix test setup

* chore: fix lint
diff --git a/autorelease/tag.py b/autorelease/tag.py
@@ -50,6 +50,16 @@ def process_issue(
     # doesn't contain all of the PR info.
     pull = gh.get_url(issue["pull_request"]["url"])
 
+    # Determine language.
+    lang = common.guess_language(gh, pull["base"]["repo"]["full_name"])
+
+    # As part of the migration to release-please tagging, cross-reference the
+    # language against an allowlist to allow migrating language-by-language.
+    if lang not in LANGUAGE_ALLOWLIST:
+        result.skipped = True
+        result.print(f"Language {lang} not in allowlist, skipping.")
+        return
+
     # Before doing any processing, check to make sure the PR was actually merged.
     # "closed" PRs can be merged or just closed without merging.
     if not pull.get("merged_at"):
@@ -61,16 +71,6 @@ def process_issue(
         )
         return
 
-    # Determine language.
-    lang = common.guess_language(gh, pull["base"]["repo"]["full_name"])
-
-    # As part of the migration to release-please tagging, cross-reference the
-    # language against an allowlist to allow migrating language-by-language.
-    if lang not in LANGUAGE_ALLOWLIST:
-        result.skipped = True
-        result.print(f"Language {lang} not in allowlist, skipping.")
-        return
-
     # Run releasetool tag for the PR.
     ctx = run_releasetool_tag(lang, gh, pull)
 
diff --git a/releasetool/filehelpers.py b/releasetool/filehelpers.py
@@ -33,7 +33,6 @@ def open_editor(filename: str, return_contents: bool = False) -> Optional[str]:
 def open_editor_with_content(
     filename: str, contents: str, return_contents: bool = False
 ) -> Optional[str]:
-
     with open(filename, "w") as fh:
         fh.write(contents)
 
diff --git a/tests/test_autorelease_tag.py b/tests/test_autorelease_tag.py
@@ -65,6 +65,7 @@ def test_run_releasetool_tag_delegates(tag_mock):
     assert ctx == context
 
 
+@patch("autorelease.tag.LANGUAGE_ALLOWLIST", ["java"])
 @patch("autorelease.tag.run_releasetool_tag")
 def test_process_issue_skips_non_merged(run_releasetool_tag):
     github = Mock()
