Skip to content

refactor: rename Salesforce to sfdx#1829

Merged
chingor13 merged 6 commits intogoogleapis:mainfrom
scolladon:refactor/salesforce-to-sfdx
Mar 14, 2023
Merged

refactor: rename Salesforce to sfdx#1829
chingor13 merged 6 commits intogoogleapis:mainfrom
scolladon:refactor/salesforce-to-sfdx

Conversation

@scolladon
Copy link
Copy Markdown
Contributor

@scolladon scolladon commented Jan 26, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1814 🦕

@scolladon scolladon requested review from a team January 26, 2023 08:26
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jan 26, 2023
@scolladon scolladon force-pushed the refactor/salesforce-to-sfdx branch from 5f4ee4f to 3745b8e Compare January 27, 2023 16:52
@scolladon
Copy link
Copy Markdown
Contributor Author

scolladon commented Jan 27, 2023

Hi @chingor13 !

I don't know why the tests are failing.
It does not seems to be related to my PR.

Should I do something on my end ?

@scolladon scolladon force-pushed the refactor/salesforce-to-sfdx branch from 257709d to 608217c Compare January 31, 2023 17:11
@scolladon scolladon requested a review from a team February 12, 2023 17:55
chingor13
chingor13 requested changes Mar 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't really take this now, because it'd be a breaking change for users. It'd be possible to rename the class while keeping an alias for users' configuration that could specify salesforce or sfdx as the release-type.

@scolladon scolladon force-pushed the refactor/salesforce-to-sfdx branch from 50201e6 to 3771b4a Compare March 7, 2023 17:40
@scolladon
Copy link
Copy Markdown
Contributor Author

scolladon commented Mar 7, 2023 •
edited
Loading

We can't really take this now, because it'd be a breaking change for users. It'd be possible to rename the class while keeping an alias for users' configuration that could specify salesforce or sfdx as the release-type.

I have added back the salesforce release-type mapper @chingor13
But I have not added it back in the documentation
This way, previous user of the salesforce release type will be able to keep using it without breaking changes
And new comers will be able to use sfdx instead

@scolladon scolladon requested a review from chingor13 March 7, 2023 17:43
chingor13
chingor13 requested changes Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, almost there.

Also, is there an issue driving the need for this rename?

Comment thread __snapshots__/cli.js Outdated
"java", "java-backport", "java-bom", "java-lts", "java-yoshi",
"java-yoshi-mono-repo", "krm-blueprint", "maven", "node", "ocaml", "php",
"php-yoshi", "python", "ruby", "ruby-yoshi", "rust", "salesforce", "simple",
"php-yoshi", "python", "ruby", "ruby-yoshi", "rust", "sfdx", "simple",
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave both salesforce and sfdx as options for the CLI in case those are being used

Comment thread __snapshots__/cli.js Outdated
"java", "java-backport", "java-bom", "java-lts", "java-yoshi",
"java-yoshi-mono-repo", "krm-blueprint", "maven", "node", "ocaml", "php",
"php-yoshi", "python", "ruby", "ruby-yoshi", "rust", "salesforce", "simple",
"php-yoshi", "python", "ruby", "ruby-yoshi", "rust", "sfdx", "simple",
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave both salesforce and sfdx as options for the CLI in case those are being used

@scolladon
Copy link
Copy Markdown
Contributor Author

scolladon commented Mar 8, 2023

Thanks, almost there.

Also, is there an issue driving the need for this rename?

I have not created a new issue, I reused the first one

@scolladon scolladon force-pushed the refactor/salesforce-to-sfdx branch from 3771b4a to 5f49249 Compare March 8, 2023 21:57
@scolladon scolladon requested a review from chingor13 March 8, 2023 21:57
@chingor13 chingor13 merged commit 122820d into googleapis:main Mar 14, 2023
@release-please release-please Bot mentioned this pull request Mar 14, 2023
Merged
@dschach
Copy link
Copy Markdown

dschach commented Mar 16, 2023

This is a good PR. Thank you, @scolladon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement Salesforce sfdx-project.json version updater

3 participants

@scolladon @dschach @chingor13