feat: add Salesforce strategy#1815
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
scolladon
force-pushed
the
feat/salesforce-strategy
branch
3 times, most recently
from
4fa8035 to
4a24c6d
Compare
scolladon
force-pushed
the
feat/salesforce-strategy
branch
from
6c50b41 to
61f4fb8
Compare
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
Thanks for this! Looks pretty good but is missing a checked in snapshot for the salesforce sfdx-project json updater
| @@ -0,0 +1,40 @@ | |||
| // Copyright 2023 Google LLC | |||
There was a problem hiding this comment.
nit: can you rename this to be sfdx-project.ts?
It will make the snapshot file named sfdx-project.js and won't collide with a potential snapshot file if we add one for the SalesforceStrategy in the future.
There was a problem hiding this comment.
Sure, thanks for the review !
There was a problem hiding this comment.
Hi @chingor13
Does the change I have done is ok for you ?
What are the next steps and how can I help ?
|
note: the test failures seem to be from weird new Octokit versions and are not related to this PR. |
scolladon
force-pushed
the
feat/salesforce-strategy
branch
from
f0591af to
b5413a2
Compare
|
@scolladon This does not work for repos with multiple package directories where each needs its own version number. #1856 |
3 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1814 🦕