Skip to content

fix: Allow linked-versions to skip merging pull requests#1779

Merged
chingor13 merged 2 commits intogoogleapis:mainfrom
luxaritas:fix/linked-merge
Mar 14, 2023
Merged

fix: Allow linked-versions to skip merging pull requests#1779
chingor13 merged 2 commits intogoogleapis:mainfrom
luxaritas:fix/linked-merge

Conversation

@luxaritas
Copy link
Copy Markdown
Contributor

@luxaritas luxaritas commented Dec 14, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea [issue linked below, this was a tiny change so figured I'd go ahead and PR instead of waiting for discussion]
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Related: #1778

@luxaritas luxaritas requested review from a team December 14, 2022 20:05
@product-auto-label product-auto-label Bot added the size: s Pull request size is small. label Dec 14, 2022
@luxaritas
Copy link
Copy Markdown
Contributor Author

luxaritas commented Feb 1, 2023

Hoping to follow up on this since it's been sitting for a bit!

@chingor13 chingor13 requested a review from a team March 14, 2023 16:23
@chingor13 chingor13 merged commit dc48b55 into googleapis:main Mar 14, 2023
@release-please release-please Bot mentioned this pull request Mar 14, 2023
Merged
@jhatler jhatler mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luxaritas @chingor13