This repository was archived by the owner on Nov 29, 2023. It is now read-only.
feat: incorporate upstream changes#73
Merged
tmatsuo merged 4 commits intogoogleapis:masterfrom Jul 31, 2020
Merged
Conversation
google-cla
Bot
added
the
cla: yes
busunkim96
reviewed
Jul 31, 2020
Comment on lines
+231
to
+243
| get supported "en-\*" voices; when specifying "no", you | ||
| will get supported "no-\*" (Norwegian) and "nb-*" | ||
| get supported "en-*" voices; when specifying "no", you | ||
| will get supported "no-*" (Norwegian) and "nb-*" | ||
| (Norwegian Bokmal) voices; specifying "zh" will also get | ||
| supported "cmn-*" voices; specifying "zh-hk" will also | ||
| get supported "yue-\*" voices. | ||
| get supported "yue-*" voices. |
Contributor
There was a problem hiding this comment.
I'm not sure why the synth replace isn't working for this, but this is the reason for the docs failure.
Contributor
Author
There was a problem hiding this comment.
Yeah, the autosynth PR also has the same thing:
Contributor
Author
There was a problem hiding this comment.
I think I figured it out:
- "((en)|(no)|(nb)(cmn)|(yue))-\*",
+ "((en)|(no)|(nb)|(cmn)|(yue))-\*",
tmatsuo
force-pushed
the
manual-synth
branch
2 times, most recently
from
8e83840 to
d7258d8
Compare
busunkim96
added
the
automerge
tmatsuo
removed
the
automerge
Contributor
Author
|
We can merge this, but isn't it better to have autosynth do the job? It'll have a better changelig I think. |
Contributor
Author
|
I'm open to merge this, but in that case, let's have a better commit logs and PR description. |
tmatsuo
changed the title
Contributor
Author
|
@busunkim96 I updated the PR title and description. How does it look? |
busunkim96
approved these changes
Jul 31, 2020
Contributor
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
@tmatsuo, could you bump these two dependencies in setup.py? They are needed for some of the new changes in this PR.
'google-api-core[grpc] >= 1.22.0, < 2.0.0dev',
'proto-plus >= 1.4.0',
added 4 commits
July 31, 2020 17:03
This PR is created by rebasing on top of googleapis#74 then manually run the synthtool.
Contributor
Author
|
I added |
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Aug 11, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.2.0](https://www.github.com/googleapis/python-texttospeech/compare/v2.1.0...v2.2.0) (2020-08-10) ### Features * incorporate upstream changes ([#73](https://www.github.com/googleapis/python-texttospeech/issues/73)) ([8ee5447](https://www.github.com/googleapis/python-texttospeech/commit/8ee544740f18497d9925bcf77e5ab96695503589)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream change:
googleapis/googleapis@a94df49