This repository was archived by the owner on Mar 31, 2026. It is now read-only.
samples: add async upload sample#665
Merged
unforced merged 9 commits intogoogleapis:mainfrom Jan 18, 2022
Merged
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
Bot
added
api: storage
andrewsg
suggested changes
Jan 18, 2022
|
|
||
|
|
||
| # [START storage_async_upload] | ||
| async def async_upload_blob(bucket_name): |
Contributor
There was a problem hiding this comment.
Can you add a comment that the sample can be run, in practice, with asyncio.run() as it is in the tests? So that people unfamiliar with async functions know they don't have to change their whole program.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI: I'll be OOO for winter holidays starting Monday, so any requested changes after business hours on Friday, please feel free to amend and merge without me.