Skip to content

Comments

feat(experimental): Add base resumption strategy for bidi streams#1594

Merged
Pulkit0110 merged 3 commits intogoogleapis:mainfrom
Pulkit0110:bidi-reads-retry
Nov 4, 2025
Merged

feat(experimental): Add base resumption strategy for bidi streams#1594
Pulkit0110 merged 3 commits intogoogleapis:mainfrom
Pulkit0110:bidi-reads-retry

Conversation

@Pulkit0110
Copy link
Member

@Pulkit0110 Pulkit0110 commented Oct 29, 2025

This PR contains abstract base class for different resumption strategies for bidi streams

@Pulkit0110 Pulkit0110 requested review from a team as code owners October 29, 2025 12:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Oct 29, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 29, 2025

Summary of Changes

Hello @Pulkit0110, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a foundational abstract base class, _BaseResumptionStrategy, designed to standardize how bidirectional streaming operations handle resumption and retry logic. This class provides a clear interface for implementing service-specific strategies, allowing for a more modular and robust retry mechanism for bidi streams by separating common retry loops from operation-specific state management and request generation.

Highlights

  • New Abstract Base Class: Introduced _BaseResumptionStrategy, an abstract base class for defining resumption strategies for bidirectional streams.
  • Standardized Interface: This class provides a standardized interface with abstract methods for generate_requests, update_state_from_response, and recover_state_on_failure.
  • Pluggable Strategy: The design aims to allow for pluggable, service-specific logic within a generic retry manager, enhancing modularity for bidi stream operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an abstract base class _BaseResumptionStrategy for handling bidi stream resumption logic. The design is sound, providing a clear interface for pluggable strategies. My review includes suggestions to improve type hinting and adhere to modern Python docstring conventions for better code clarity and maintainability.

chandra-siri
chandra-siri reviewed Nov 3, 2025
View reviewed changes
@Pulkit0110 Pulkit0110 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 4, 2025
@Pulkit0110 Pulkit0110 merged commit 5fb85ea into googleapis:main Nov 4, 2025
15 checks passed
@release-please release-please bot mentioned this pull request Nov 4, 2025
Merged
@Pulkit0110 Pulkit0110 deleted the bidi-reads-retry branch January 2, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chandra-siri chandra-siri chandra-siri approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@chandra-siri chandra-siri

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pulkit0110 @chandra-siri