Skip to content

Comments

feat(zb-experimental): Add support for closing MRD#1554

Merged
chandra-siri merged 83 commits intomainfrom
bidi_reads_7
Sep 30, 2025
Merged

feat(zb-experimental): Add support for closing MRD#1554
chandra-siri merged 83 commits intomainfrom
bidi_reads_7

Conversation

@chandra-siri
Copy link
Collaborator

@chandra-siri chandra-siri commented Sep 25, 2025

  • add is_stream_open and check it's value before doing any of the following operation. open , close , send ,recv
  • Instantiate socket_like_rpc inside open, so that it is a new object every time we open.
    • Otherwise, consider this scenario where a user is opening after closing then initial_request would be None because close sets it to None.

this will be the parent class for AsyncReadObjectStream and AsyncWriteObjectStream
…ython-storage into bidi_reads_2_read_obj_stream
…ython-storage into bidi_reads_2_read_obj_stream
…python-storage into bidi_reads_3_read_obj_stream
…ython-storage into bidi_reads_2_read_obj_stream
…python-storage into bidi_reads_3_read_obj_stream
…ython-storage into bidi_reads_2_read_obj_stream
…python-storage into bidi_reads_3_read_obj_stream
…python-storage into bidi_reads_4_read_obj_stream
@chandra-siri chandra-siri requested review from a team as code owners September 25, 2025 17:36
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Sep 25, 2025
Base automatically changed from bidi_reads_6_read_obj_stream to main September 29, 2025 07:54
Pulkit0110
Pulkit0110 previously approved these changes Sep 30, 2025
@chandra-siri chandra-siri merged commit 9c8856a into main Sep 30, 2025
15 checks passed
@chandra-siri chandra-siri deleted the bidi_reads_7 branch September 30, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants