Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: use native namespace to avoid pkg_resources warnings#1176

Merged
parthea merged 12 commits intomainfrom
native_namespace
Nov 9, 2023
Merged

fix: use native namespace to avoid pkg_resources warnings#1176
parthea merged 12 commits intomainfrom
native_namespace

Conversation

@andrewsg
Copy link
Copy Markdown
Contributor

@andrewsg andrewsg commented Nov 4, 2023

Fixes #1000 🦕

@andrewsg andrewsg requested review from a team November 4, 2023 01:01
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Nov 4, 2023
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Nov 4, 2023 •
edited
Loading

Sorry I accidentally clicked the close button while I was typing..

For other google-cloud-* libraries, we'll follow the same change in googleapis/google-auth-library-python#1205 which includes switching to find_namespace_packages as described in https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages

@parthea parthea closed this Nov 4, 2023
@parthea parthea reopened this Nov 4, 2023
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 8, 2023
@andrewsg
Copy link
Copy Markdown
Contributor Author

andrewsg commented Nov 8, 2023

@parthea Thank you very much. PTAL

@andrewsg andrewsg requested a review from parthea November 8, 2023 01:09
parthea
parthea reviewed Nov 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove namespace_packages= in setup.py and add a packaging test similar to https://github.com/googleapis/google-auth-library-python/pull/1205/files

@andrewsg
Copy link
Copy Markdown
Contributor Author

andrewsg commented Nov 8, 2023

@parthea Test will be added after dependencies are updated, see googleapis/google-cloud-python#15980 . Took care of the setup.py updates. PTAL

@parthea parthea merged commit 2ed915e into main Nov 9, 2023
@parthea parthea deleted the native_namespace branch November 9, 2023 10:10
@release-please release-please Bot mentioned this pull request Nov 9, 2023
Merged
@parthea parthea mentioned this pull request Dec 7, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@parthea parthea parthea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DeprecationWarning for pkg_resources.declare_namespace usage in google.cloud

2 participants

@andrewsg @parthea