Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

Update README.rst#233

Merged
IlyaFaer merged 1 commit intomainfrom
IlyaFaer-patch-1
Aug 18, 2022
Merged

Update README.rst#233
IlyaFaer merged 1 commit intomainfrom
IlyaFaer-patch-1

Conversation

@IlyaFaer
Copy link
Copy Markdown

@IlyaFaer IlyaFaer commented Aug 18, 2022

Tiny docs improvement in order to reduce users' confusion about migrations rollback.
Closes #230

@product-auto-label product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Aug 18, 2022
Comment thread README.rst
to ``False`` can cause migration problems.
to ``False`` can cause migration problems.

Also notice that DDL statements in Spanner are not transactional and will not be automatically reverted in case of a migration fail.
Copy link
Copy Markdown
Author

@IlyaFaer IlyaFaer Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a small note about DDLs into this section as well to make sure users understand the mechanism

@IlyaFaer IlyaFaer requested a review from asthamohta August 18, 2022 08:40
@IlyaFaer IlyaFaer merged commit 8bab5fb into main Aug 18, 2022
@IlyaFaer IlyaFaer deleted the IlyaFaer-patch-1 branch August 18, 2022 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve docs for DDLs are not transactionally executed

2 participants