Skip to content

tests: retry 'create_instance_with_processing_units' on 429 #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 4 commits into from
Jul 19, 2021
Merged

tests: retry 'create_instance_with_processing_units' on 429 #419

tseaver merged 4 commits into from
Jul 19, 2021

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 16, 2021

Closes #416.

@tseaver tseaver added the samples Issues that are directly related to samples. label Jul 16, 2021
@tseaver tseaver requested a review from larkee July 16, 2021 17:12
@tseaver tseaver requested review from a team as code owners July 16, 2021 17:12
@tseaver tseaver requested review from dandhlee and removed request for a team July 16, 2021 17:12
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 16, 2021
larkee
larkee reviewed Jul 19, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the default settings of RetryErrors is suitable for this case.

The default settings are as follows:

MAX_TRIES = 4
DELAY = 1s
BACKOFF = 2

I think setting the delay to 15 may make more sense. WDYT?

@tseaver tseaver merged commit ee31e8a into master Jul 19, 2021
@tseaver tseaver deleted the 416-snippets-retry-instance-creation branch July 19, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larkee larkee larkee left review comments

@dandhlee dandhlee Awaiting requested review from dandhlee

+1 more reviewer

@zoercai zoercai zoercai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

samples/snippets.py: test_create_instance_with_processing_units flakes with 429

3 participants

@tseaver @zoercai @larkee