Skip to content

Conversation

@chalmerlowe
Copy link
Contributor

@chalmerlowe chalmerlowe commented Nov 14, 2025

This PR adds support for Python 3.14 to the library.

Key changes include:

Key changes include:

  • Updates to owlbot.py to include Python 3.14.
  • Adding Python 3.14 to the test matrix in .github/workflows/presubmit.yaml.
  • Verified setup.py includes the Python 3.14 classifier.
  • Verified CONTRIBUTING.rst includes Python 3.14.
  • Verified noxfile.py updates for 3.14.
  • Updated Kokoro configurations in .kokoro/presubmit/ to use system-3.14 session.
  • Updated librarian.py to account for post-processing.
  • Fixed a concurrency issue in tests/unit/test_spanner.py to make the test suite pass on Python 3.14.

Towards internal issue: b/375664027

@chalmerlowe chalmerlowe requested review from a team as code owners November 14, 2025 18:39
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 14, 2025
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Nov 14, 2025
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 14, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 17, 2025
chalmerlowe and others added 12 commits November 17, 2025 11:16
…transaction_with_batch_update thread-safe\n\nUses a custom assertion to compare call arguments and metadata structure\nwithout relying on the exact order of execution in threads, and more robustly checks the request IDs.
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 833474957

Source-Link:
googleapis/googleapis@7418c8b

Source-Link:
googleapis/googleapis-gen@f969a4a
Copy-Tag:
eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjk2OWE0YTVhZDk5N2JhZjE4OWMzOTkzMTYyOTdkNjBhODE5ODg1YiJ9

BEGIN_NESTED_COMMIT
feat: Add Send and Ack mutations for Queues
feat: Add QueryAdvisorResult for query plan
docs: Update description for the BatchCreateSessionsRequest and Session
docs: Update description for the IsolationLevel

PiperOrigin-RevId: 832425466

Source-Link:
googleapis/googleapis@0eeb1be

Source-Link:
googleapis/googleapis-gen@bae4179
Copy-Tag:
eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmFlNDE3OTI1MjAzZTY4YzgwNmQ5ZjZiZmUzYzIwYWIzY2JmNWQ4NiJ9
END_NESTED_COMMIT

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Make built-in metrics enabled by default

This change inverts the logic for enabling built-in OpenTelemetry
metrics. Previously, metrics were disabled by default and could be
enabled by setting `ENABLE_SPANNER_METRICS_ENV_VAR=true`.

With this update, metrics are now enabled by default to provide better
out-of-the-box observability for users.

To disable metrics, users must now set the new environment variable:
`SPANNER_DISABLE_BUILTIN_METRICS=true`

The old `ENABLE_SPANNER_METRICS_ENV_VAR` is no longer used. Unit tests
have been updated to reflect this new opt-out behavior.

**BREAKING CHANGE**: Built-in metrics are now enabled by default. Users
who previously did not set any environment variables will have metrics
collection and export turned on automatically after upgrading. To
restore the previous behavior and disable metrics, thry have to set the
`SPANNER_DISABLE_BUILTIN_METRICS` environment variable to `true`.
@chalmerlowe chalmerlowe requested a review from a team as a code owner December 9, 2025 18:52
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Dec 9, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Dec 9, 2025
@chalmerlowe chalmerlowe merged commit 7e30073 into main Dec 10, 2025
23 checks passed
@chalmerlowe chalmerlowe deleted the feat/add-python-3.14 branch December 10, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants