observability: PDML + some batch write spans #1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
odeke-em
force-pushed
the
trace-pdml
branch
2 times, most recently
from
c11580f to
7dfb796
Compare
Contributor
Author
|
@harshachinta @olavloite kindly help me run the bots for this PR. Thank you. |
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
@harshachinta @olavloite kindly help me re-run the bots, I had to account for Python3.7 in the tests and fixed that, all pass locally. |
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
harshachinta
reviewed
Jan 8, 2025
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
harshachinta
reviewed
Jan 8, 2025
tests/unit/test_snapshot.py
Outdated
Comment on lines
1233
to
1234
| if not HAS_OPENTELEMETRY_INSTALLED: | ||
| return |
Contributor
There was a problem hiding this comment.
This is not needed right since assertSpanAttributes method already checks for this condition?
Contributor
Author
There was a problem hiding this comment.
Yeah, before I was manually comparing attributes and span names but with the update that I made I no longer need it, done, thanks!
tests/unit/test_snapshot.py
Outdated
Comment on lines
1231
to
1244
| attributes=dict( | ||
| BASE_ATTRIBUTES, table_id=TABLE_NAME, columns=tuple(COLUMNS) | ||
| ), | ||
| attributes=want_span_attributes, |
Contributor
There was a problem hiding this comment.
Nothing has changed here? why not keep it the same?
Contributor
Author
|
@harshachinta kindly help me run the bots. Thank you |
sakthivelmanii
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
harshachinta
approved these changes
Jan 10, 2025
This change adds spans for Partitioned DML and making updates for Batch. Carved out from PR googleapis#1241.
Contributor
Author
|
@harshachinta all done, kindly help me kick off the bots! |
Contributor
Author
|
@alkatrivedi @sakthivelmanii kindly help me run the bots |
harshachinta
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds spans for Partitioned DML and making updates for Batch.
Carved out from PR #1241.