Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

tracing: update OpenTelemetry dependencies from 2021 to 2024#1199

Merged
harshachinta merged 1 commit intogoogleapis:mainfrom
odeke-em:trace-use-updated-otel-library
Sep 18, 2024
Merged

tracing: update OpenTelemetry dependencies from 2021 to 2024#1199
harshachinta merged 1 commit intogoogleapis:mainfrom
odeke-em:trace-use-updated-otel-library

Conversation

@odeke-em
Copy link
Copy Markdown
Contributor

@odeke-em odeke-em commented Sep 11, 2024 •
edited
Loading

This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:

  • otel.scope.name
  • otel.scope.version

Also added a modernized example and updated the docs.

Updates #1170
Fixes #1173
Built from PR #1172

@odeke-em odeke-em requested review from a team September 11, 2024 04:14
@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch from 149484b to c906c09 Compare September 11, 2024 04:23
@odeke-em odeke-em changed the title opentelemetry-tracing: update dependencies from 2021 to 2024 tracing: update OpenTelemetry dependencies from 2021 to 2024 Sep 11, 2024
@odeke-em
Copy link
Copy Markdown
Contributor Author

odeke-em commented Sep 11, 2024

Kindly cc-ing you @harshachinta. /cc @willpoint

@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Sep 11, 2024
@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch from c906c09 to 3389806 Compare September 11, 2024 05:49
@odeke-em
Copy link
Copy Markdown
Contributor Author

odeke-em commented Sep 11, 2024

Exhibit

With this change and the example/trace.py being ran, we get back these traces
Screenshot 2024-09-10 at 7 51 08 PM
Screenshot 2024-09-10 at 7 51 19 PM
Screenshot 2024-09-10 at 7 51 43 PM

@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch 4 times, most recently from ffbc624 to 4092436 Compare September 12, 2024 09:11
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 13, 2024
harshachinta
harshachinta reviewed Sep 13, 2024
View reviewed changes
Comment thread google/cloud/spanner_v1/_opentelemetry_tracing.py Outdated
harshachinta
harshachinta reviewed Sep 13, 2024
View reviewed changes
Comment thread google/cloud/spanner_v1/_opentelemetry_tracing.py
harshachinta
harshachinta reviewed Sep 13, 2024
View reviewed changes
Comment thread tests/_helpers.py Outdated
harshachinta
harshachinta reviewed Sep 13, 2024
View reviewed changes
Comment thread tests/unit/test__opentelemetry_tracing.py Outdated
harshachinta
harshachinta reviewed Sep 13, 2024
View reviewed changes
Comment thread examples/trace.py Outdated
@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch from 685f2c8 to d573f04 Compare September 16, 2024 10:50
@odeke-em
Copy link
Copy Markdown
Contributor Author

odeke-em commented Sep 16, 2024

@harshachinta kindly please see my replies to your review comments. Thank you!

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2024
@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch 3 times, most recently from 4c1d4bc to 9ff8017 Compare September 17, 2024 04:01
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@harshachinta harshachinta added the automerge Merge the pull request once unit tests and other checks pass. label Sep 17, 2024
@product-auto-label product-auto-label Bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 17, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@harshachinta harshachinta removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 17, 2024
harshachinta
harshachinta reviewed Sep 17, 2024
View reviewed changes
Comment thread tests/system/test_session_api.py Outdated
@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch 4 times, most recently from 22f37e6 to 04db2a7 Compare September 17, 2024 08:38
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch from 04db2a7 to 2645ab5 Compare September 17, 2024 12:31
@odeke-em
Copy link
Copy Markdown
Contributor Author

odeke-em commented Sep 17, 2024

@harshachinta all updates made, kindly help me kick off the Kokoro bots, and thank you for the reviews too!

@odeke-em odeke-em mentioned this pull request Sep 17, 2024
Closed
2 tasks
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 17, 2024
@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch from 69d9519 to 250f687 Compare September 17, 2024 20:44
@odeke-em
tracing: update OpenTelemetry dependencies from 2021 to 2024
c5e2f30 
This change non-invasively introduces dependencies of opentelemetry
bringing in the latest dependencies and modernizing them.

While here also brought in modern span attributes:
* otel.scope.name
* otel.scope.version

Also added a modernized example to produce traces as well
with gRPC-instrumentation enabled, and updated the docs.

Updates googleapis#1170
Fixes googleapis#1173
Built from PR googleapis#1172
@odeke-em odeke-em force-pushed the trace-use-updated-otel-library branch from 250f687 to c5e2f30 Compare September 17, 2024 21:01
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2024
@harshachinta harshachinta merged commit cb8a2b7 into googleapis:main Sep 18, 2024
@odeke-em odeke-em mentioned this pull request Nov 7, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@harshachinta harshachinta harshachinta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@manu2 manu2

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

4 participants

@odeke-em @harshachinta @manu2 @yoshi-kokoro