Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

chore: update README and setup scripts#193

Merged
parthea merged 6 commits intogoogleapis:mainfrom
tetiana-karasova:main
Mar 30, 2022
Merged

chore: update README and setup scripts#193
parthea merged 6 commits intogoogleapis:mainfrom
tetiana-karasova:main

Conversation

@t-karasova
Copy link
Copy Markdown
Contributor

@t-karasova t-karasova commented Mar 22, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@t-karasova t-karasova requested a review from a team as a code owner March 22, 2022 00:14
@t-karasova t-karasova requested a review from a team March 22, 2022 00:14
@product-auto-label product-auto-label Bot added the api: retail Issues related to the googleapis/python-retail API. label Mar 22, 2022
chenlei1216
chenlei1216 approved these changes Mar 22, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/README.md Outdated
busunkim96
busunkim96 reviewed Mar 22, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/README.md
```bash
pip install virtualenv
virtualenv myenv
virtualenv -p python3 myenv
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Virtualenv is installed by default on python3:

https://docs.python.org/3/library/venv.html#creating-virtual-environments

python3 -m venv myenv

Copy link
Copy Markdown
Contributor Author

@t-karasova t-karasova Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to is because the CloudShell by default still has the python 2.7

Comment thread samples/interactive-tutorials/README.md
1. Log in with your user credentials to run a code sample from the Cloud Shell:

```bash
gcloud auth login
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be google auth application-default login?

https://cloud.google.com/sdk/gcloud/reference/auth/application-default/login

Copy link
Copy Markdown
Contributor Author

@t-karasova t-karasova Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no - if we use default authentication we have permission denied error creating the big query tables

@t-karasova t-karasova changed the title update README docs(samples): update README and setup scripts Mar 24, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 24, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 24, 2022
@kweinmeister kweinmeister requested a review from parthea March 24, 2022 20:10
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 24, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 24, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 24, 2022
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Mar 25, 2022
parthea
parthea approved these changes Mar 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations, otherwise LGTM

Comment thread samples/interactive-tutorials/user_environment_setup.sh
Comment thread samples/interactive-tutorials/user_import_data_to_catalog.sh
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 28, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 29, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 29, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 29, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 30, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 30, 2022
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 30, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 30, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 30, 2022
@parthea parthea changed the title docs(samples): update README and setup scripts chore: update README and setup scripts Mar 30, 2022
@parthea parthea merged commit 0046cc2 into googleapis:main Mar 30, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@busunkim96 busunkim96 busunkim96 left review comments

@parthea parthea parthea approved these changes

@chenlei1216 chenlei1216 chenlei1216 approved these changes

@kweinmeister kweinmeister kweinmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: retail Issues related to the googleapis/python-retail API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@t-karasova @parthea @chenlei1216 @busunkim96 @kweinmeister @yoshi-kokoro @tetiana-karasova