Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

chore: Replace str.format() and string concatenation in samples with f-string#186

Merged
parthea merged 9 commits intogoogleapis:mainfrom
tetiana-karasova:format_fix
Mar 10, 2022
Merged

chore: Replace str.format() and string concatenation in samples with f-string#186
parthea merged 9 commits intogoogleapis:mainfrom
tetiana-karasova:format_fix

Conversation

@t-karasova
Copy link
Copy Markdown
Contributor

@t-karasova t-karasova commented Mar 10, 2022 •
edited by parthea
Loading

Fixes #164 🦕

@t-karasova t-karasova requested a review from a team as a code owner March 10, 2022 12:52
@t-karasova t-karasova requested a review from a team March 10, 2022 12:52
@product-auto-label product-auto-label Bot added api: retail Issues related to the googleapis/python-retail API. samples Issues that are directly related to samples. labels Mar 10, 2022
@parthea parthea changed the title chore: Issue #164: Replace str.format() and string concatenation in samples with f-string chore: Replace str.format() and string concatenation in samples with f-string Mar 10, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
parthea
parthea approved these changes Mar 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread samples/interactive-tutorials/events/setup_events/setup_cleanup.py Outdated
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
parthea
parthea reviewed Mar 10, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/product/set_inventory.py Outdated
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
chenlei1216
chenlei1216 approved these changes Mar 10, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/events/rejoin_user_event.py Outdated
Comment thread samples/interactive-tutorials/test_resources_recovery/create_test_resources.py Outdated
@kweinmeister kweinmeister added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 10, 2022
parthea
parthea reviewed Mar 10, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/events/write_user_event.py Outdated
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2022
@parthea parthea merged commit 8ece55c into googleapis:main Mar 10, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@parthea parthea parthea approved these changes

@chenlei1216 chenlei1216 chenlei1216 approved these changes

@kweinmeister kweinmeister kweinmeister approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: retail Issues related to the googleapis/python-retail API. owlbot:run Add this label to trigger the Owlbot post processor. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace str.format() and string concatenation in samples with f-string

6 participants

@t-karasova @parthea @chenlei1216 @kweinmeister @yoshi-kokoro @tetiana-karasova