Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

docs(samples): read the project id from google.auth#160

Merged
parthea merged 4 commits intogoogleapis:mainfrom
tetiana-karasova:product-id
Feb 25, 2022
Merged

docs(samples): read the project id from google.auth#160
parthea merged 4 commits intogoogleapis:mainfrom
tetiana-karasova:product-id

Conversation

@tetiana-karasova
Copy link
Copy Markdown
Contributor

@tetiana-karasova tetiana-karasova commented Feb 22, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tetiana-karasova tetiana-karasova requested a review from a team as a code owner February 22, 2022 13:53
@tetiana-karasova tetiana-karasova requested a review from a team February 22, 2022 13:53
@product-auto-label product-auto-label Bot added api: retail Issues related to the googleapis/python-retail API. samples Issues that are directly related to samples. labels Feb 22, 2022
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Feb 22, 2022 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kweinmeister kweinmeister added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 22, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 22, 2022
kweinmeister
kweinmeister reviewed Feb 22, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/search/search_simple_query.py
chenlei1216
chenlei1216 reviewed Feb 25, 2022
View reviewed changes
Comment thread samples/interactive-tutorials/search/utils.py Outdated
@parthea parthea changed the title docs(samples): read the project id from gcloud config docs(samples): read the project id from google.auth Feb 25, 2022
@parthea parthea mentioned this pull request Feb 25, 2022
Closed
@parthea parthea added owlbot:run Add this label to trigger the Owlbot post processor. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 25, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 25, 2022
@parthea parthea mentioned this pull request Feb 25, 2022
Closed
@parthea parthea self-assigned this Feb 25, 2022
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Feb 25, 2022

Ready to merge once tests pass

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@parthea parthea merged commit f6192c8 into googleapis:main Feb 25, 2022
@release-please release-please Bot mentioned this pull request Feb 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@chenlei1216 chenlei1216 chenlei1216 left review comments

@kweinmeister kweinmeister kweinmeister left review comments

@parthea parthea parthea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@parthea parthea

Labels

api: retail Issues related to the googleapis/python-retail API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tetiana-karasova @parthea @chenlei1216 @kweinmeister @yoshi-kokoro