Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Docs: Add attributes to pubsub_v1.types#921

Merged
acocuzzo merged 7 commits intomainfrom
add-attributes
May 23, 2023
Merged

Docs: Add attributes to pubsub_v1.types#921
acocuzzo merged 7 commits intomainfrom
add-attributes

Conversation

@acocuzzo
Copy link
Copy Markdown
Contributor

A attribute descriptions in google/cloud/pubsub_v1/types in order to popular documentation properly:
following this format:

class BigQueryConfig(proto.Message):

@acocuzzo acocuzzo requested a review from a team as a code owner May 18, 2023 19:31
@acocuzzo acocuzzo requested a review from a team May 18, 2023 19:31
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels May 18, 2023
Copy link
Copy Markdown
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Few comments.

@acocuzzo acocuzzo merged commit 4607dca into main May 23, 2023
@acocuzzo acocuzzo deleted the add-attributes branch May 23, 2023 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants