fix: remove dependency on pytz #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: pubsub
google-cla
bot
added
the
cla: yes
Contributor
|
I resolved the merge conflict through the web, I think it should be fine now (no tooling at my disposal, will see what the CI checks say). |
plamut
approved these changes
Aug 13, 2021
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
Looks good, no traces of pytz anymore, thanks for this!
Closed
Contributor
|
The Pub/Sub Lite samples check failure is external, i.e. not caused by this PR. Update: It was a sample for the code that had not been released yet at the time, but now a new version of Pub/Sub Lite has been released. Re-running the checks. |
plamut
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
plamut
added
automerge
yoshi-kokoro
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 19, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.7.1](https://www.github.com/googleapis/python-pubsub/compare/v2.7.0...v2.7.1) (2021-08-13) ### Bug Fixes * remove dependency on pytz ([#472](https://www.github.com/googleapis/python-pubsub/issues/472)) ([972cc16](https://www.github.com/googleapis/python-pubsub/commit/972cc163f5a1477b37a5ab7e329faf1468637fa2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For googleapis/python-api-core#250
Fixes #468.