Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

docs(samples): Increase example max_bytes setting for cloud storage subscriptions to encourage more performant subscribe#1324

Merged
mukund-ananthu merged 2 commits intogoogleapis:mainfrom
lahuang4:main
Jan 31, 2025
Merged

docs(samples): Increase example max_bytes setting for cloud storage subscriptions to encourage more performant subscribe#1324
mukund-ananthu merged 2 commits intogoogleapis:mainfrom
lahuang4:main

Conversation

@lahuang4
Copy link
Copy Markdown
Contributor

@lahuang4 lahuang4 commented Jan 10, 2025

No description provided.

@lahuang4
docs(samples): Increase example max_bytes setting for cloud storage s…
8b2e475 
…ubscriptions to encourage more performant subscribe
@lahuang4 lahuang4 requested a review from a team as a code owner January 10, 2025 00:55
@lahuang4 lahuang4 requested review from a team and balajismaniam January 10, 2025 00:55
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 10, 2025
@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Jan 10, 2025
@mukund-ananthu mukund-ananthu enabled auto-merge (squash) January 10, 2025 01:05
@hongalex
Copy link
Copy Markdown
Member

hongalex commented Jan 10, 2025

Just noticed this sample isn't on https://cloud.google.com/pubsub/docs/create-cloudstorage-subscription

@lahuang4
Copy link
Copy Markdown
Contributor Author

lahuang4 commented Jan 13, 2025

Oh interesting, I found it from https://cloud.google.com/pubsub/docs/samples/pubsub-create-cloud-storage-subscription#pubsub_create_cloud_storage_subscription-python.

Will look into updating the https://cloud.google.com/pubsub/docs/create-cloudstorage-subscription page to link all the existing samples.

@lahuang4
Copy link
Copy Markdown
Contributor Author

lahuang4 commented Jan 13, 2025

It looks like the Kokoro build failed, but it was a different test case which failed:

=================================== FAILURES ===================================
__________________ test_opentelemetry_flow_control_exception ___________________

...

        spans = span_exporter.get_finished_spans()
        # Span 1 = Publisher Flow Control Span of first publish
        # Span 2 = Publisher Batching Span of first publish
        # Span 3 = Publisher Flow Control Span of second publish(raises FlowControlLimitError)
        # Span 4 = Publish Create Span of second publish(raises FlowControlLimitError)
>       assert len(spans) == 4
E       assert 5 == 4
E        +  where 5 = len((, , ))

tests/unit/pubsub_v1/publisher/test_publisher_client.py:301: AssertionError

@hongalex could you help me re-run the Kokoro check? Not sure how to trigger it myself.

(Looks like there is already an issue opened for the test being flaky: #1309)

@briandorsey briandorsey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@lahuang4 lahuang4 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2025
@mukund-ananthu
Copy link
Copy Markdown
Contributor

mukund-ananthu commented Jan 13, 2025

@parthea The Owlbot PostProcessor seems to be stuck indefinitely despite multiple force-runs. Could you PTAL / is this a known issue. cc: @lahuang4

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 31, 2025
@mukund-ananthu mukund-ananthu merged commit cb760a7 into googleapis:main Jan 31, 2025
@release-please release-please bot mentioned this pull request Jan 31, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balajismaniam balajismaniam Awaiting requested review from balajismaniam balajismaniam is a code owner automatically assigned from googleapis/python-samples-reviewers

1 more reviewer

@mukund-ananthu mukund-ananthu mukund-ananthu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mukund-ananthu mukund-ananthu

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@lahuang4 @hongalex @mukund-ananthu @briandorsey @parthea @yoshi-kokoro