Skip to content

tests: Resolve connections deprecation warning #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parthea merged 3 commits into from
Jan 3, 2025
Merged

tests: Resolve connections deprecation warning #1310

parthea merged 3 commits into from
Jan 3, 2025

Conversation

@xionams
Copy link
Contributor

@xionams xionams commented Dec 3, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1206 🦕

@xionams xionams requested review from a team as code owners December 3, 2024 11:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Dec 3, 2024
@parthea parthea changed the title Fix (#1206) connections deprecation warning tests: Resolve connections deprecation warning Jan 3, 2025
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 3, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 3, 2025
@parthea parthea merged commit f79d35a into googleapis:main Jan 3, 2025
24 checks passed
@parthea
Copy link
Contributor

parthea commented Jan 3, 2025

Thanks @xionams!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

Assignees

@mukund-ananthu mukund-ananthu

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix DeprecationWarning: connections() is deprecated and will be removed; use net_connections() instead

4 participants

@xionams @parthea @yoshi-kokoro @mukund-ananthu