This repository was archived by the owner on Mar 9, 2026. It is now read-only.
chore: Remove restriction that protobuf should be less than 5#1193
Merged
mukund-ananthu merged 3 commits intomainfrom Jun 20, 2024
Merged
chore: Remove restriction that protobuf should be less than 5#1193mukund-ananthu merged 3 commits intomainfrom
mukund-ananthu merged 3 commits intomainfrom
Conversation
Contributor
Author
|
@parthea PTAL when free. |
|
I would very much like to have this fixed as well, for similar reasons to #1192 |
parthea
approved these changes
Jun 19, 2024
Co-authored-by: Anthonios Partheniou <[email protected]>
Contributor
|
Also update Change python-pubsub/testing/constraints-3.7.txt Line 10 in 0b8d7b9 to |
78ee38b to
5995757
Compare
Contributor
|
The system tests are failing due to an unrelated issue. |
3df084a to
86ecee0
Compare
86ecee0 to
cd879a6
Compare
Contributor
Author
|
@jeffsawatzky and @cglewis . The fix is submitted and available in the latest release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see that an upper bound of 5 was set on the protobuf library in 23ce35e
I do not find any documentation on reasons for keeping an upper bound. Proposing removing the upper bound in this PR, but also checking if there are any reasons we would not want to do this from @parthea who would have historical context on this.
Fixes #1192 🦕
BEGIN_COMMIT_OVERRIDE
fix: allow Protobuf 5.x
END_COMMIT_OVERRIDE