This repository was archived by the owner on Mar 9, 2026. It is now read-only.
feat: add use_topic_schema for Cloud Storage Subscriptions#1154
Merged
feat: add use_topic_schema for Cloud Storage Subscriptions#1154
Conversation
PiperOrigin-RevId: 629071173 Source-Link: googleapis/googleapis@4afa392 Source-Link: googleapis/googleapis-gen@16dbbb4 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZkYmJiNGQwNDU3ZGI1ZTYxYWM5Zjk5YjBkNTJhNDYxNTQ0NTVhYyJ9
3bace30 to
1b18b15
Compare
PiperOrigin-RevId: 638641437 Source-Link: googleapis/googleapis@a3016a8 Source-Link: googleapis/googleapis-gen@2001c33 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjAwMWMzMzBhZWU2MmE5ZDRlOGE5ODUyZDhlNWJmMjY2MjgxOGFkNCJ9
PiperOrigin-RevId: 638650618 Source-Link: googleapis/googleapis@6330f03 Source-Link: googleapis/googleapis-gen@44fa4f1 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9
Contributor
|
cc: @parthea Could we rope in the code generator library owners for GAPIC for them to fix the code generator libraries to ensure the code doesn't break unit tests like they are now: |
Contributor
|
Following up on #1154 (comment), the test that is failing is part of the handwritten code. We can follow up on a long term solution via googleapis/google-cloud-python#16295. In the meantime, the following change fixes the issue. |
mukund-ananthu
approved these changes
Jul 2, 2024
PiperOrigin-RevId: 649277844 Source-Link: googleapis/googleapis@fd7efa2 Source-Link: googleapis/googleapis-gen@50be251 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTBiZTI1MTMyOWQ4ZGI1YjU1NTYyNmViZDQ4ODY3MjFmNTQ3ZDNjYyJ9
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 649277844
Source-Link: googleapis/googleapis@fd7efa2
Source-Link: https://github.com/googleapis/googleapis-gen/commit/50be251329d8db5b555626ebd4886721f547d3cc
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTBiZTI1MTMyOWQ4ZGI1YjU1NTYyNmViZDQ4ODY3MjFmNTQ3ZDNjYyJ9
BEGIN_NESTED_COMMIT
feat: add use_topic_schema for Cloud Storage Subscriptions
PiperOrigin-RevId: 643385701
BEGIN_COMMIT_OVERRIDE
feat: add use_topic_schema for Cloud Storage Subscriptions
feat: add service_account_email for export subscriptions
END_COMMIT_OVERRIDE
Source-Link: googleapis/googleapis@f29a82a
Source-Link: https://github.com/googleapis/googleapis-gen/commit/f8f3f60ad2ab4e81fe024368ad0430900174e82b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjhmM2Y2MGFkMmFiNGU4MWZlMDI0MzY4YWQwNDMwOTAwMTc0ZTgyYiJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: Update gapic-generator-python to v1.18.0
PiperOrigin-RevId: 638650618
Source-Link: googleapis/googleapis@6330f03
Source-Link: https://github.com/googleapis/googleapis-gen/commit/44fa4f1979dc45c1778fd7caf13f8e61c6d1cae8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDRmYTRmMTk3OWRjNDVjMTc3OGZkN2NhZjEzZjhlNjFjNmQxY2FlOCJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add service_account_email for export subscriptions
PiperOrigin-RevId: 638641437
Source-Link: googleapis/googleapis@a3016a8
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2001c330aee62a9d4e8a9852d8e5bf2662818ad4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjAwMWMzMzBhZWU2MmE5ZDRlOGE5ODUyZDhlNWJmMjY2MjgxOGFkNCJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: Update gapic-generator-python to v1.17.1
PiperOrigin-RevId: 629071173
Source-Link: googleapis/googleapis@4afa392
Source-Link: https://github.com/googleapis/googleapis-gen/commit/16dbbb4d0457db5e61ac9f99b0d52a46154455ac
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTZkYmJiNGQwNDU3ZGI1ZTYxYWM5Zjk5YjBkNTJhNDYxNTQ0NTVhYyJ9
END_NESTED_COMMIT