Skip to content

Conversation

@busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Aug 12, 2021

@busunkim96 busunkim96 requested a review from andrewsg as a code owner August 12, 2021 20:21
@busunkim96 busunkim96 requested a review from a team August 12, 2021 20:21
@busunkim96 busunkim96 requested a review from a team as a code owner August 12, 2021 20:21
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Aug 12, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021
@chrisrossi
Copy link
Contributor

This appears to be a whitespace-only change.

@chrisrossi
Copy link
Contributor

This appears to be a whitespace-only change.

Nevermind, was accidentally looking at diff for single commit

@chrisrossi
Copy link
Contributor

Unfortunately, NDB is still required to support Python 2.7, where datetime.timezone.utc is not present. If I understand the problem to be addressed properly, we probably just need to add the pytz dependency to setup.py instead.

@busunkim96
Copy link
Contributor Author

@chrisrossi Ah makes sense. I backed out the original changes and just added pytz to the setup.py.

Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisrossi chrisrossi merged commit 6b48548 into master Aug 12, 2021
@chrisrossi chrisrossi deleted the remove-pytz branch August 12, 2021 23:02
oliverchang added a commit to google/clusterfuzz that referenced this pull request Aug 27, 2021
oliverchang added a commit to google/clusterfuzz that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants