Skip to content
This repository was archived by the owner on Oct 16, 2023. It is now read-only.

chore: add constraints file#47

Merged
gcf-merge-on-green[bot] merged 8 commits intomasterfrom
add-constraints-file
Mar 30, 2021
Merged

chore: add constraints file#47
gcf-merge-on-green[bot] merged 8 commits intomasterfrom
add-constraints-file

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

Add constraints file to test lower bounds. These files will not be used until the noxfile is changed in googleapis/synthtool#869.

@busunkim96 busunkim96 requested a review from a team December 30, 2020 21:47
@product-auto-label product-auto-label Bot added the api: iam Issues related to the googleapis/python-iam API. label Dec 30, 2020
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 30, 2020
Copy link
Copy Markdown
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor observation

Comment thread testing/constraints-3.6.txt Outdated
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Mar 30, 2021

@busunkim96 PTAL

@busunkim96 busunkim96 requested a review from parthea March 30, 2021 14:57
@parthea parthea added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 30, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 30, 2021
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 6f08bca into master Mar 30, 2021
@gcf-merge-on-green gcf-merge-on-green Bot deleted the add-constraints-file branch March 30, 2021 18:42
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: iam Issues related to the googleapis/python-iam API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants