Repository navigation
fix: Exclude derived parsed field when reparsing merged continuation responses - #3351
copybara-service[bot] wants to merge 1 commit into
Conversation
733af5d to
fcb53d0
Compare
| [ | ||
| ( | ||
| {'response_json_schema': {'type': 'object'}}, | ||
| {'title': 'x'}, |
|
kaulastudies
left a comment
kaulastudies
left a comment
There was a problem hiding this comment.
One non-blocking regression-test suggestion: could we also cover a stale parsed value when the merged text cannot be parsed?
The new stale-hop test replaces an old value with valid merged JSON. Two useful companion cases would be malformed merged JSON, and valid JSON that fails _Summary validation (for example, a missing title). Seed an earlier hop with _Summary(title='stale'), then assert that the merged response follows the normal parse-failure behavior and does not retain that earlier value.
This would protect the failure path as well as successful reparsing. I reviewed the diff; I have not run these cases against the SDK.
…responses fixes #3350 PiperOrigin-RevId: 1018798936
fcb53d0 to
6db934b
Compare
fix: Exclude derived parsed field when reparsing merged continuation responses
fixes #3350