Repository navigation
fix: escape backslash in ClaudeFile.filename description - #3309
Open
VISHNU0906 wants to merge 1 commit into
Open
VISHNU0906 wants to merge 1 commit into
VISHNU0906 wants to merge 1 commit into
Conversation
The File.filename Field description and TypedDict docstring used `\/` in a regular string, which triggers SyntaxWarning on Python 3.12+ when google.genai is imported. Escape as `\\/` so the documented character set still includes both `\` and `/`. Fixes googleapis#3308 Signed-off-by: KVR Vishnu <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importing
google.genaion Python 3.12+ emits:ClaudeFile.filename(Field description and TypedDict docstring) used\/in a regular string. Escape it as\\/so the documented rejected character set still includes both\and/, with no warning.Fixes #3308
cc @s-banach
Notes
google/genai/types.pyis marked generated (DO NOT EDIT). The generator / schema that emits this description is not in this public tree, so this PR patches the checked-in output. Please mirror the escape in the generator source so a regen does not reintroduce the warning.Test plan
python -W error::SyntaxWarning -c "import google.genai"succeedscompile(..., 'exec')oftypes.pyreports zeroSyntaxWarnings\and/pytest google/genai/tests/imports/(2 passed, 1 skipped)