Repository navigation
fix: Echo function_call.id into AFC function responses - #3201
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
copybara/1005076557
branch
from
October 22, 2026 22:25
7087454 to
634d88f
Compare
chrikrah
reviewed
Nov 5, 2026
chrikrah
left a comment
There was a problem hiding this comment.
This closes #3192 as I reported it: the #3192 probe now sends call_1 and call_2 back on both paths. From my side it's ready to merge.
$ python -I afc_id_probe.py # the #3192 script, google/genai/__init__.py from a 634d88f export, google-genai 2.32.0, CPython 3.12
generate_content [{"id": "call_1", "name": "get_weather", ...}, {"id": "call_2", "name": "get_weather", ...}]
generate_content_stream [{"id": "call_1", ...}, {"id": "call_2", ...}]
# _extra_utils.py from the parent adbc79c: both lines lose their "id" again
$ python -m pytest -q google/genai/tests/afc
125 passed, 4 errors # 634d88f; the 4 are replay tests that need credentials
120 passed, 4 errors # adbc79c
# _extra_utils.py from adbc79c, the new tests kept: 4 failed, 6 passed
Swapping Part.from_function_response for the constructor loses nothing, since the helper only forwards name, response and parts. Is the live API meant to pair responses by id from here on, as live.py:725 already requires?
copybara-service
Bot
force-pushed
the
copybara/1005076557
branch
2 times, most recently
from
November 5, 2026 10:44
18e3706 to
f7b181c
Compare
fixes #3192 PiperOrigin-RevId: 1005076557
copybara-service
Bot
force-pushed
the
copybara/1005076557
branch
from
November 5, 2026 16:57
f7b181c to
fcdb2be
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Echo function_call.id into AFC function responses
fixes #3192