feat!: Begin using new microgenerator for v2 firestore #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
…nto onboard-microgen
Contributor
Author
|
Kokoro Test is Skipping System, which is odd, running locally. |
Contributor
Author
|
Coverage is at 97%, not 100%. Considering, temporarily, dropping this and filing an issue. Docs issue tbd. |
Closed
Contributor
Author
|
I recommend viewing a selection of commits to make this a bit more palatable: https://github.com/googleapis/python-firestore/pull/91/files/538cb05b70c96a637c1b12cf0c69a2925fc45686..94210e3625b63a40a7e76698eba529e8ab3da0a3 |
rafilong
reviewed
Jul 13, 2020
rafilong
reviewed
Jul 13, 2020
rafilong
reviewed
Jul 13, 2020
Contributor
rafilong
left a comment
rafilong
left a comment
There was a problem hiding this comment.
LGTM! Most of the comments I had were clarifying confusion on my end.
rafilong
reviewed
Jul 14, 2020
Closed
Closed
This was referenced Aug 20, 2020
Closed
Closed
This was referenced Oct 26, 2020
This was referenced Nov 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits early on split off to separate out generated bits from edits to (hopefully) ease reviewing