Skip to content

fix: harden lookup of credentials id_token attribute #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crwilcox merged 1 commit into from
Aug 26, 2021
Merged

fix: harden lookup of credentials id_token attribute #434

crwilcox merged 1 commit into from
Aug 26, 2021

Conversation

@crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Aug 26, 2021

Fixes #433

@crwilcox crwilcox requested a review from a team August 26, 2021 20:44
@crwilcox crwilcox requested a review from a team as a code owner August 26, 2021 20:44
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Aug 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2021
@crwilcox crwilcox merged commit e28272a into googleapis:main Aug 26, 2021
@crwilcox crwilcox deleted the fix-433 branch August 26, 2021 22:18
@parthea parthea mentioned this pull request Aug 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: firestore Issues related to the googleapis/python-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accessing Firestore document in Firebase emulator fails with AttributeError

2 participants

@crwilcox @kolea2