-
Notifications
You must be signed in to change notification settings - Fork 30
chore: migrate to main branch #201
Conversation
parthea
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor observations, otherwise LGTM.
README.rst
Outdated
|
|
||
| .. |GA| image:: https://img.shields.io/badge/support-ga-gold.svg | ||
| :target: https://github.com/googleapis/google-cloud-python/blob/master/README.rst#general-availability | ||
| :target: https://github.com/googleapis/google-cloud-python/blob/main/README.rst#general-availability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get 404 with the new link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
samples/AUTHORING_GUIDE.md
Outdated
| @@ -1 +1 @@ | |||
| See https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md No newline at end of file | |||
| See https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get 404 with the new link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
Please take a look again! |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #199 🦕