Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Conversation

@dandhlee
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #199 🦕

@dandhlee dandhlee requested a review from parthea August 24, 2021 02:35
@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 02:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@product-auto-label product-auto-label bot added the api: documentai Issues related to the googleapis/python-documentai API. label Aug 24, 2021
@dandhlee dandhlee requested review from a team as code owners August 24, 2021 02:37
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor observations, otherwise LGTM.

README.rst Outdated

.. |GA| image:: https://img.shields.io/badge/support-ga-gold.svg
:target: https://github.com/googleapis/google-cloud-python/blob/master/README.rst#general-availability
:target: https://github.com/googleapis/google-cloud-python/blob/main/README.rst#general-availability
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 with the new link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@@ -1 +1 @@
See https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md No newline at end of file
See https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 with the new link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dandhlee dandhlee changed the title docs: migrate to main branch chore: migrate to main branch Aug 24, 2021
@dandhlee dandhlee requested a review from parthea August 24, 2021 21:37
@dandhlee
Copy link
Contributor Author

Please take a look again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: documentai Issues related to the googleapis/python-documentai API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to main branch

2 participants