build: treat warnings as errors (#237)

parthea · web-flow · commit 5a8b4f28bc2e · 2023-11-30T15:34:03.000-05:00
* build: treat warnings as errors

* ignore warnings from googleapis-common-protos

* remove grpc from system test which is not used in this library
diff --git a/noxfile.py b/noxfile.py
@@ -190,11 +190,6 @@ def unit(session):
 
 
 def install_systemtest_dependencies(session, *constraints):
-    # Use pre-release gRPC for system tests.
-    # Exclude version 1.52.0rc1 which has a known issue.
-    # See https://github.com/grpc/grpc/issues/32163
-    session.install("--pre", "grpcio!=1.52.0rc1")
-
     session.install(*SYSTEM_TEST_STANDARD_DEPENDENCIES, *constraints)
 
     if SYSTEM_TEST_EXTERNAL_DEPENDENCIES:
diff --git a/owlbot.py b/owlbot.py
@@ -32,5 +32,13 @@
 
 python.py_samples(skip_readmes=True)
 
+s.replace(
+    "noxfile.py",
+    """    # Use pre-release gRPC for system tests.
+    # Exclude version 1.52.0rc1 which has a known issue.
+    # See https://github.com/grpc/grpc/issues/32163
+    session.install\("--pre", "grpcio!=1.52.0rc1"\)""",
+    ""
+)
 s.shell.run(["nox", "-s", "blacken"], hide_output=False)
 
diff --git a/pytest.ini b/pytest.ini
@@ -0,0 +1,11 @@
+[pytest]
+filterwarnings =
+    # treat all warnings as errors
+    error
+    # Remove once https://github.com/protocolbuffers/protobuf/issues/12186 is fixed
+    ignore:.*custom tp_new.*in Python 3.14:DeprecationWarning
+    # Remove once https://github.com/googleapis/python-cloud-core/issues/259 is fixed
+    ignore:datetime.datetime.utcnow\(\) is deprecated:DeprecationWarning
+    # Remove once https://github.com/googleapis/python-api-common-protos/pull/187/files is merged
+    ignore:.*pkg_resources.declare_namespace:DeprecationWarning
+    ignore:.*pkg_resources is deprecated as an API:DeprecationWarning
