Skip to content
This repository was archived by the owner on Jan 6, 2024. It is now read-only.

docs(samples): Added LRO code snippet#220

Merged
galz10 merged 7 commits intogoogleapis:mainfrom
galz10:LRO-snippet
Jan 6, 2022
Merged

docs(samples): Added LRO code snippet#220
galz10 merged 7 commits intogoogleapis:mainfrom
galz10:LRO-snippet

Conversation

@galz10
Copy link
Copy Markdown
Contributor

@galz10 galz10 commented Dec 15, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@galz10 galz10 requested a review from a team as a code owner December 15, 2021 19:09
@galz10 galz10 requested a review from dandhlee December 15, 2021 19:09
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Dec 15, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. samples Issues that are directly related to samples. labels Dec 15, 2021
@galz10 galz10 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 15, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 15, 2021
@galz10 galz10 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 4, 2022
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2022
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2022
dandhlee
dandhlee reviewed Jan 6, 2022
View reviewed changes
Comment thread samples/snippets/long_running_operation.py Outdated
Comment thread samples/snippets/long_running_operation.py Outdated
@galz10 galz10 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2022
@galz10 galz10 requested a review from dandhlee January 6, 2022 22:48
dandhlee
dandhlee approved these changes Jan 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@galz10 galz10 merged commit b23b515 into googleapis:main Jan 6, 2022
@galz10 galz10 deleted the LRO-snippet branch January 6, 2022 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@dandhlee dandhlee dandhlee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dialogflow Issues related to the googleapis/python-dialogflow-cx API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@galz10 @dandhlee @yoshi-kokoro