fix: raise ValueError if date is out-of-bounds #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
tswast
commented
Dec 3, 2021
| ], | ||
| type=pyarrow.time64("ns"), | ||
| ), | ||
| id="time-nanoseconds-arrow-round-trip", |
Collaborator
Author
There was a problem hiding this comment.
Leftover from debugging why when I made the "time" _datetime method return a Timestamp too, this broke. Since that change isn't necessary and it broke this test I reverted it. Kept the test id, since I thought it was useful.
tswast
commented
Dec 3, 2021
| minute=int(minute) if minute else 0, | ||
| second=int(second) if second else 0, | ||
| nanosecond=nanosecond, | ||
| ).to_datetime64() |
Collaborator
Author
There was a problem hiding this comment.
Probably should have been a separate PR, but I noticed _datetime had inconsistent types (sometimes pandas.Timestamp, sometime datetime.datetime, sometime numpy.datetime64). We want a numpy.datetime64 in the end, so I unified it.
plamut
approved these changes
Dec 4, 2021
| ], | ||
| type=pyarrow.time64("ns"), | ||
| ), | ||
| id="time-nanoseconds-arrow-round-trip", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #45 🦕
Edit: Maybe should be just "Towards" #45 because I think we still need some way to support out-of-range values so that I can load DATE values when using the conversion logic googleapis/python-bigquery-pandas#441