Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 5, 2021

Closes #206.

@tseaver tseaver requested a review from a team August 5, 2021 18:22
@tseaver tseaver requested a review from a team as a code owner August 5, 2021 18:22
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-datastore API. label Aug 5, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2021
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@tseaver tseaver merged commit cf77e60 into master Aug 5, 2021
@tseaver tseaver deleted the 206-test-prerelease-deps-on-python-3.9 branch August 5, 2021 18:46
tseaver added a commit that referenced this pull request Aug 17, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 18, 2021
Reverts #207

Consensus from today's meeting is that testing prereleases of third-party dependencies needs to happen outside the normal `presubmit` path.
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Nov 24, 2025
Reverts googleapis/python-datastore#207

Consensus from today's meeting is that testing prereleases of third-party dependencies needs to happen outside the normal `presubmit` path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the googleapis/python-datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add unit tests against pre-release versions of dependencies

2 participants