This repository was archived by the owner on Sep 5, 2023. It is now read-only.
chore: migrate to main branch #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datalabeling
google-cla
bot
added
the
cla: yes
dandhlee
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
dandhlee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
parthea
reviewed
Aug 24, 2021
Contributor
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
Added minor observations, otherwise LGTM.
UPGRADING.md
Outdated
| In the 1.0.0 release, all methods have a single positional parameter `request`. Method docstrings indicate whether a parameter is required or optional. | ||
|
|
||
| Some methods have additional keyword only parameters. The available parameters depend on the [`google.api.method_signature` annotation](https://github.com/googleapis/googleapis/blob/master/google/cloud/datalabeling/v1beta1/data_labeling_service.proto#L48) specified by the API producer. | ||
| Some methods have additional keyword only parameters. The available parameters depend on the [`google.api.method_signature` annotation](https://github.com/googleapis/googleapis/blob/main/google/cloud/datalabeling/v1beta1/data_labeling_service.proto#L48) specified by the API producer. |
Contributor
There was a problem hiding this comment.
I get 404 with the new link
README.rst
Outdated
|
|
||
| .. _Data Labeling API Product documentation: https://cloud.google.com/data-labeling/docs | ||
| .. _repository’s main README: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/README.rst | ||
| .. _repository’s main README: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/main/README.rst |
Contributor
There was a problem hiding this comment.
I get 404 with the new link
samples/AUTHORING_GUIDE.md
Outdated
| @@ -1 +1 @@ | |||
| See https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md No newline at end of file | |||
| See https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I get 404 with the new link
Contributor
Author
|
Please take a look again! |
parthea
approved these changes
Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #137 🦕