Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Conversation

@dandhlee
Copy link
Contributor

@dandhlee dandhlee commented Aug 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Will update python-docs-samples repo accordingly as well.

Fixes #210 🦕

@dandhlee dandhlee requested a review from parthea August 24, 2021 00:51
@dandhlee dandhlee requested a review from a team as a code owner August 24, 2021 00:51
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2021
@product-auto-label product-auto-label bot added the api: datacatalog Issues related to the googleapis/python-datacatalog API. label Aug 24, 2021
@dandhlee dandhlee added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 24, 2021
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations, otherwise LGTM.

@dandhlee dandhlee changed the title docs: migrate to main branch chore: migrate to main branch Aug 24, 2021
@dandhlee
Copy link
Contributor Author

Please take a look again!

@dandhlee dandhlee requested a review from parthea August 24, 2021 22:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datacatalog Issues related to the googleapis/python-datacatalog API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to main branch

3 participants