This repository was archived by the owner on Dec 31, 2023. It is now read-only.
docs(samples): Samples for custom vm types #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 8 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
api: compute
google-cla
bot
added
the
cla: yes
m-strzelczyk
changed the title
product-auto-label
bot
added
the
samples
savijatv
reviewed
Nov 19, 2021
Contributor
savijatv
left a comment
savijatv
left a comment
There was a problem hiding this comment.
@m-strzelczyk , reviewed changes in the files. Are these files reviewed before the changes were made in this PR?
engelke
approved these changes
Dec 6, 2021
engelke
left a comment
engelke
left a comment
There was a problem hiding this comment.
Needs some fixes. See comments and failing tests. Once passing, LGTM.
m-strzelczyk
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Some commentary about what is in this code sample. Since the documentation for custom machine types has very little in the means of examples for the API category, I figured it'd be nice to provide our users with something more useful, than just a bunch of strings showing the proper custom machine type string formatting.
I decided to implement a class, that customers can use to make their life easier when dealing with custom machine types. This class should take care of validating the proper CPU/memory values, provide the "extra memory" switch and handle the formatting of the string for them.
The examples we will then provide in the documentation page will show how to use this class, but also how to use simple strings, if someone doesn't want to use the helper class.