Skip to content

fix: populate SQL app_profile_id header even when it is unset #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackdingilian merged 1 commit into from
Apr 17, 2025
Merged

fix: populate SQL app_profile_id header even when it is unset #1109

jackdingilian merged 1 commit into from
Apr 17, 2025

Conversation

@jackdingilian
Copy link
Contributor

@jackdingilian jackdingilian commented Apr 16, 2025 •
edited
Loading

This should be identical to #1072, which was overridden by the newest gapic changes. It also adds support for prepare_query in addition to execute_query

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jackdingilian jackdingilian requested review from a team as code owners April 16, 2025 21:47
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. labels Apr 16, 2025
@jackdingilian jackdingilian force-pushed the rls-sql branch 3 times, most recently from dea7a54 to cbaede7 Compare April 17, 2025 00:25
@gkevinzheng
Copy link
Contributor

gkevinzheng commented Apr 17, 2025

Since this is a GAPIC-related issue, this will happen again once a new GAPIC library gets generated. Could you look into using s.replace in Owlbot to resolve this?

@jackdingilian jackdingilian added owlbot:run Add this label to trigger the Owlbot post processor. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2025
@jackdingilian jackdingilian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 17, 2025
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 17, 2025
@gkevinzheng gkevinzheng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 17, 2025
@jackdingilian jackdingilian merged commit 17b75bd into googleapis:main Apr 17, 2025
28 of 30 checks passed
@jackdingilian jackdingilian deleted the rls-sql branch April 17, 2025 16:54
@release-please release-please bot mentioned this pull request Apr 17, 2025
Merged
@daniel-sanche daniel-sanche mentioned this pull request Apr 26, 2025
Merged
@sarahec sarahec mentioned this pull request May 1, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

Assignees

@mutianf mutianf

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackdingilian @gkevinzheng @mutianf @yoshi-kokoro