Skip to content

feat: Implement SQL support in test proxy #1106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daniel-sanche merged 5 commits into from
Jun 12, 2025
Merged

feat: Implement SQL support in test proxy #1106

daniel-sanche merged 5 commits into from
Jun 12, 2025

Conversation

@jackdingilian
Copy link
Contributor

@jackdingilian jackdingilian commented Apr 2, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@jackdingilian jackdingilian requested review from a team as code owners April 2, 2025 17:53
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Apr 2, 2025
@jackdingilian jackdingilian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
daniel-sanche
daniel-sanche reviewed May 2, 2025
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes mostly LGTM, but do you know why the tests are now failing? Is it because of the updated protos?

test_proxy/handlers/sql_encoding.py
# limitations under the License.
"""
This module contains helpers for handling sql data types for the test proxy.
"""
Copy link
Contributor

@daniel-sanche daniel-sanche May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be outside of the handlers folder, and maybe renamed to something like sql_encoding_helpers.py

Or if putting it in a parent folder is tricky, you can make a handlers/helpers folder and put it in there

Copy link
Contributor Author

@jackdingilian jackdingilian Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@daniel-sanche
Copy link
Contributor

daniel-sanche commented May 19, 2025

@jackdingilian Maybe for this PR we should just ignore the proto updates? Right now our conformance tests are locked on to tag v0.0.2, which doesn't use any btsql functionality. Updating to the latest version of the conformance tests will require a few new library features, and likely won't be prioritized until closer to the end of the year

Maybe for this PR, we should just focus on getting execute_query into the test_proxy so it's ready, and then we'll re-generate the protos in the future when we bump up the conformance test tag?

Let me know what you think

@jackdingilian jackdingilian added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2025
daniel-sanche
daniel-sanche approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We will have to update the test tag for the sql tests to run, but that can come as a follow up

@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 12, 2025
@daniel-sanche daniel-sanche merged commit 7a91bbf into googleapis:main Jun 12, 2025
28 of 30 checks passed
@release-please release-please bot mentioned this pull request Jul 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

Assignees

@gkevinzheng gkevinzheng

Labels

api: bigtable Issues related to the googleapis/python-bigtable API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackdingilian @daniel-sanche @yoshi-kokoro @gkevinzheng