Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

Conversation

@shollyman
Copy link
Contributor

These system tests rely on a public dataset table: bigquery-public-data.new_york_citibike.citibike_stations

The schema of this table recently changed, and a formerly int64 column was switched to a string type. This PR updates that by switching from the affected column to another column less likely to suffer type conversions in the future (num_bikes_available).

Fixes: #558
Fixes: #559
Fixes: #560
Fixes: #561
Fixes: #562
Fixes: #563

These system tests rely on a public dataset table:
bigquery-public-data.new_york_citibike.citibike_stations

The schema of this table recently changed, and a formerly int64 column
was switched to a string type.  This PR updates that by switching from
the affected column to another column less likely to suffer type
conversions in the future (num_bikes_available).

Fixes: googleapis#558
Fixes: googleapis#559
Fixes: googleapis#560
Fixes: googleapis#561
Fixes: googleapis#562
Fixes: googleapis#563
@shollyman shollyman requested a review from a team as a code owner January 27, 2023 18:22
@shollyman shollyman requested review from a team and chalmerlowe January 27, 2023 18:22
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. labels Jan 27, 2023
Copy link

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman merged commit 2df7874 into googleapis:main Jan 27, 2023
@shollyman shollyman deleted the darn_you_public_datasets branch January 27, 2023 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. size: xs Pull request size is extra small.

Projects

None yet

2 participants