This repository was archived by the owner on Nov 12, 2025. It is now read-only.
chore: remove hack for installing extras from synth.py#118
Merged
tswast merged 8 commits intogoogleapis:masterfrom Jan 28, 2021
Merged
chore: remove hack for installing extras from synth.py#118tswast merged 8 commits intogoogleapis:masterfrom
tswast merged 8 commits intogoogleapis:masterfrom
Conversation
tswast
requested review from
a team and
stephaniewang526
and removed request for
a team
product-auto-label
Bot
added
the
api: bigquerystorage
google-cla
Bot
added
the
cla: yes
tswast
added
the
do not merge
tswast
requested review from
shollyman and
steffnay
and removed request for
stephaniewang526
1 task
tswast
removed
the
do not merge
Contributor
Author
|
Ready for review. |
plamut
approved these changes
Jan 27, 2021
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
This looks good IMO. 👍
And thanks for adding that synthtool improvement in the first place.
plamut
suggested changes
Jan 27, 2021
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
I just realized pyarrow==3.0.0 was released yesterday, meaning that conditionally installing it is not needed anymore (well, at least until we start thinking Python 3.10 support 😆 ).
Let's remove that logic then.
Contributor
Author
|
@plamut removed Python 3.9 exception and re-ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the templates added in
googleapis/synthtool#906
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Closes #115