Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Dec 8, 2021

Eventually we will want to migrate these to Kokoro (or even GitHub actions using https://github.com/google-github-actions/auth) but just remove the broken session for now. The prerelease run is redundant with the session we recently added, so replace it with a session using the latest released pandas via conda.

The reason we're not removing the conda sessions completely is that pandas recommends installation via conda/mamba. Since pandas-gbq is an optional dependency of pandas, we need to ensure this package is also always installable via conda/mamba.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #424 🦕

@tswast tswast requested a review from a team as a code owner December 8, 2021 15:54
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Dec 8, 2021
@tswast
Copy link
Collaborator Author

tswast commented Dec 8, 2021

Kokoro prerelease session is currently failing, but should be fixed by #445

@tswast tswast requested review from loferris and plamut December 8, 2021 16:23
Copy link
Contributor

@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 9, 2021
@tswast
Copy link
Collaborator Author

tswast commented Dec 9, 2021

I need to investigate the package conflict in the 3.10 conda session.

@tswast
Copy link
Collaborator Author

tswast commented Dec 9, 2021

Can't build with conda-3.10 until conda-forge/google-cloud-bigquery-feedstock#106 is resolved. I'll update the config to use Python 3.9 for now.

@tswast tswast requested a review from a team December 9, 2021 17:14
@tswast tswast added automerge Merge the pull request once unit tests and other checks pass. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit c0f9da0 into googleapis:main Dec 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 9, 2021
@tswast tswast deleted the issue424-conda-nightlies branch December 9, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-pandas API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CircleCI tests with prerelease (nightlies) are failing due to conda timeout

2 participants