This repository was archived by the owner on Mar 13, 2026. It is now read-only.
test: upload DATE column with various dtypes#420
Merged
Conversation
google-cla
Bot
added
the
cla: yes
product-auto-label
Bot
added
the
api: bigquery
tswast
commented
Nov 11, 2021
…igquery-pandas into issue362-to_gbq-date
Merged
4 tasks
plamut
approved these changes
Nov 12, 2021
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
Looks good, with a question about (not) hardcoding the Python version for db-dtypes system tests.
| # virtualenv's dist-packages. | ||
| session.install("mock", "pytest", "google-cloud-testutils", "-c", constraints_path) | ||
| session.install("-e", ".[tqdm]", "-c", constraints_path) | ||
| if session.python == "3.9": |
There was a problem hiding this comment.
So, we only want to test db-types under a single Python version, 3.9 in this case? It's not a range restriction?
Does the 3.9 version have any specific meaning, or is it more like "recent, but not the latest" kind of choice?
If the latter, we could probably say SYSTEM_TEST_PYTHON_VERSIONS[-2] to avoid hardcoding.
Update: I see this will be removed in the follow-up PR (#423).
Contributor
Author
There was a problem hiding this comment.
I think that was because we needed some code paths where it wasn't present, but #423 adds db-dtypes as a proper dependency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #362 🦕